[PATCH xserver] modesetting: use drmmode_bo_import() for rotate_fb

[Olivier Fourdan]

On Fri, Jun 15, 2018 at 8:57 AM, Olivier Fourdan <ofourdan at redhat.com> wrote:
> drmmode_shadow_allocate() still uses drmModeAddFB() which may fail if
> the format is not as expected, preventing from using a rotated output.
>
> Change it to use the new function drmmode_bo_import() which takes care
> of calling the drmModeAddFB2() API.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106715
> Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>
> ---
>  hw/xfree86/drivers/modesetting/drmmode_display.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c b/hw/xfree86/drivers/modesetting/drmmode_display.c
> index 859a21a9d..ec11b3f56 100644
> --- a/hw/xfree86/drivers/modesetting/drmmode_display.c
> +++ b/hw/xfree86/drivers/modesetting/drmmode_display.c
> @@ -1794,11 +1794,8 @@ drmmode_shadow_allocate(xf86CrtcPtr crtc, int width, int height)
>          return NULL;
>      }
>
> -    ret = drmModeAddFB(drmmode->fd, width, height, crtc->scrn->depth,
> -                       drmmode->kbpp,
> -                       drmmode_bo_get_pitch(&drmmode_crtc->rotate_bo),
> -                       drmmode_bo_get_handle(&drmmode_crtc->rotate_bo),
> -                       &drmmode_crtc->rotate_fb_id);
> +    ret = drmmode_bo_import(drmmode, &drmmode_crtc->rotate_bo,
> +                            &drmmode_crtc->rotate_fb_id);
>
>      if (ret) {
>          ErrorF("failed to add rotate fb\n");
> --
> 2.17.1
>

Tested successfully downstream by Tom Pelka, so adding:

Tested-by: Tomas Pelka <tpelka at redhat.com>

Thanks Tom!

Olivier.