[PATCH xserver] xawyland/glamor: Fix typo in xwl_glamor_pixmap_get_wl_buffer

Olivier Fourdan fourdan at gmail.com
Fri Jun 8 07:28:03 UTC 2018


Hi Vivek,

On Fri, 8 Jun 2018 at 09:23, Vivek Das Mohapatra <vivek at collabora.com> wrote:
>
> In the #else path of the #ifdef GBM_BO_WITH_MODIFIERS in
> xwl_glamor_pixmap_get_wl_buffer there's a call to
> gbm_go_get_stride: This should be gbm_bo_get_stride.
>
> Typo introduced in c8c276c9569b3ca1e695682a5443f1b615c606bd.
> ---
>  hw/xwayland/xwayland-glamor-gbm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xwayland/xwayland-glamor-gbm.c b/hw/xwayland/xwayland-glamor-gbm.c
> index 29325adac..68c2cc32e 100644
> --- a/hw/xwayland/xwayland-glamor-gbm.c
> +++ b/hw/xwayland/xwayland-glamor-gbm.c
> @@ -272,7 +272,7 @@ xwl_glamor_gbm_get_wl_buffer_for_pixmap(PixmapPtr pixmap,
>  #else
>      num_planes = 1;
>      modifier = DRM_FORMAT_MOD_INVALID;
> -    strides[0] = gbm_go_get_stride(xwl_pixmap->bo);
> +    strides[0] = gbm_bo_get_stride(xwl_pixmap->bo);
>      offsets[0] = 0;
>  #endif
>
> --
> 2.11.0
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel

Thanks for the patch, but this is a duplicate, a similar patch was
already submitted and reviewed here:

https://patchwork.freedesktop.org/series/43867/

Cheers,
Olivier


More information about the xorg-devel mailing list