[PATCH xserver 10/10] xwayland: EGL_IMG_context_priority required by EGLStream

Emil Velikov emil.l.velikov at gmail.com
Tue Jun 5 19:23:09 UTC 2018


On 5 June 2018 at 18:38, Olivier Fourdan <ofourdan at redhat.com> wrote:
> xwl_glamor_eglstream_init_egl() uses "EGL_IMG_context_priority"
> extension, make sure it's actually available before using it.
>
> Suggested-by: Emil Velikov <emil.velikov at collabora.com>
> Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>
> ---
>  hw/xwayland/xwayland-glamor-eglstream.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/hw/xwayland/xwayland-glamor-eglstream.c b/hw/xwayland/xwayland-glamor-eglstream.c
> index c226c0089..43f34eed1 100644
> --- a/hw/xwayland/xwayland-glamor-eglstream.c
> +++ b/hw/xwayland/xwayland-glamor-eglstream.c
> @@ -794,6 +794,12 @@ xwl_glamor_eglstream_init_egl(struct xwl_screen *xwl_screen)
>          goto error;
>      }
>
> +    if (!epoxy_has_egl_extension(xwl_screen->egl_display,
> +                                 "EGL_IMG_context_priority")) {
> +        ErrorF("EGL_IMG_context_priority not available\n");
> +        goto error;
> +    }
> +
Another approach is to adjust the array to omit the attributes.
Either way, the series is:

Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks for going through my nit-picky suggestions.
Emil


More information about the xorg-devel mailing list