[PATCH xserver 3/5] xwayland: Add Wayland interfaces check

[Emil Velikov]

On 1 June 2018 at 15:31, Olivier Fourdan <ofourdan at redhat.com> wrote:

> +static Bool
> +xwl_glamor_gbm_has_wl_interfaces(struct xwl_screen *xwl_screen)
> +{
> +    struct xwl_gbm_private *xwl_gbm = xwl_gbm_get(xwl_screen);
> +
> +    if (xwl_gbm->drm == NULL) {
> +        ErrorF("glamor: 'wl_drm' not supported\n");
> +        return FALSE;
> +    }
> +
Please add a comment about dmabuf. I know it's optional, but in the
long run we'd want it instead of wl_drm ;-)


> @@ -69,6 +69,11 @@ struct xwl_egl_backend {
>                               const char *name, uint32_t id,
>                               uint32_t version);
>
> +    /* Check that the required Wayland interfaces are available. This
> +     * callback is optional.
Since it's implemented by both backends, so I'd call it mandatory and
drop the NULL check in xwl_glamor_has_wl_interfaces.

-Emil