[PATCH app/xev] xev: fix 'mode' in default case (version 2)

[Walter Harms]

Hello Eitan,
thx for your effort just a general remark:
be verbose what you are changing and why (it took me a while to notice the , ->
; change)
exspecialy if it fixed a bug (e.g. "... otherwise abc is never assigned.")

Dito changes in patches, it is ok to fix a patch, just write it inside like:

V2: fix also second occurence 
V1: fixes warning

got the idea ?

re,
 wh


> Eitan Adler <lists at eitanadler.com> hat am 28. Juli 2018 um 10:28 geschrieben:
> 
> 
> Signed-off-by: Eitan Adler <lists at eitanadler.com>
> ---
>  xev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xev.c b/xev.c
> index 6cde09a..638eae7 100644
> --- a/xev.c
> +++ b/xev.c
> @@ -225,7 +225,7 @@ do_EnterNotify (XEvent *eventp)
>        case NotifyGrab:  mode = "NotifyGrab"; break;
>        case NotifyUngrab:  mode = "NotifyUngrab"; break;
>        case NotifyWhileGrabbed:  mode = "NotifyWhileGrabbed"; break;
> -      default:  mode = dmode, sprintf (dmode, "%u", e->mode); break;
> +      default:  mode = dmode; sprintf (dmode, "%u", e->mode); break;
>      }
>  
>      switch (e->detail) {
> @@ -265,7 +265,7 @@ do_FocusIn (XEvent *eventp)
>        case NotifyGrab:  mode = "NotifyGrab"; break;
>        case NotifyUngrab:  mode = "NotifyUngrab"; break;
>        case NotifyWhileGrabbed:  mode = "NotifyWhileGrabbed"; break;
> -      default:  mode = dmode, sprintf (dmode, "%u", e->mode); break;
> +      default:  mode = dmode; sprintf (dmode, "%u", e->mode); break;
>      }
>  
>      switch (e->detail) {
> -- 
> 2.18.0
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel