[PATCH xserver 6/7] dix: Switch window unmap to mark normally instead of UnmapValData

Keith Packard keithp at keithp.com
Tue Jul 24 21:10:42 UTC 2018


Adam Jackson <ajax at redhat.com> writes:

> ---
>  dix/window.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dix/window.c b/dix/window.c
> index 55290577d9..34bed93d93 100644
> --- a/dix/window.c
> +++ b/dix/window.c
> @@ -2870,7 +2870,7 @@ UnmapWindow(WindowPtr pWin, Bool fromConfigure)
>      if (SubStrSend(pWin, pParent))
>          DeliverUnmapNotify(pWin, fromConfigure);
>      if (wasPaintable && !fromConfigure) {
> -        pWin->valdata = UnmapValData;
> +        (*pScreen->MarkWindow) (pWin);

Hrm. This drops a pretty significant optimization on the floor; perhaps
we no longer care though?

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20180724/f4a2e95c/attachment.sig>


More information about the xorg-devel mailing list