[PATCH xserver 08/10] xf86-video-modesetting: Create CONNECTOR_ID properties for outputs

Adam Jackson ajax at nwnk.net
Tue Jan 23 16:16:47 UTC 2018


On Tue, 2018-01-23 at 11:32 +1100, Keith Packard wrote:
> Adam Jackson <ajax at nwnk.net> writes:
> 
> > > +        if (name != BAD_RESOURCE) {
> > > +            err = RRConfigureOutputProperty(output->randr_output, name,
> > > +                                            FALSE, TRUE, TRUE,
> > > +                                            2, prop_range);
> > 
> > There's no good reason to make this a range, is there?
> 
> Well, it's a fixed integer for each output, which can either be
> considered an enumeration which can have only one value or a value in a
> range. I picked 'range' because it didn't seem like this could be
> considered an enumeration to me.
> 
> If you like the other option better, that'd be fine with me :-)

I think I do like an enum better, even if only for the xrandr output
formatting:

	CONNECTOR_ID: 58 
		range: (0, 2147483647)
	non-desktop: 0 
		supported: 0, 1

If CONNECTOR_ID were an enum that'd just be "supported" with only one
value, making it clear ahead of time that there's no point trying to
change it.

- ajax


More information about the xorg-devel mailing list