[PATCH xserver 1/4] animcur: Use fixed-size screen private

Adam Jackson ajax at redhat.com
Mon Jan 8 19:44:47 UTC 2018


On Fri, 2018-01-05 at 16:55 -0800, Aaron Plattner wrote:
> On 11/12/2017 04:35 PM, Robert Morell wrote:
> > On Mon, Nov 06, 2017 at 03:19:51PM -0500, Adam Jackson wrote:
> > 
> > > @@ -101,7 +98,6 @@ AnimCurCloseScreen(ScreenPtr pScreen)
> > >       Unwrap(as, pScreen, RealizeCursor);
> > >       Unwrap(as, pScreen, UnrealizeCursor);
> > >       Unwrap(as, pScreen, RecolorCursor);
> > > -    SetAnimCurScreen(pScreen, 0);
> > >       ret = (*pScreen->CloseScreen) (pScreen);
> > >       free(as);
> > 
> > The free() above should be removed as well, otherwise it causes a
> > double-free on screen teardown.
> > 
> > Other than that,
> > 
> > Reviewed-by: Robert Morell <rmorell at nvidia.com>
> > Tested-by: Robert Morell <rmorell at nvidia.com>
> > 
> > for the series.
> 
> At least two users have hit this now:
> https://devtalk.nvidia.com/default/topic/1028172/linux/titan-v-ubuntu-16-04lts-and-387-34-driver-crashes-badly/post/5230799/#5230799
> 
> Adam, can this series be merged?

Yep, thanks for the reminder. Fixed the issue Robert mentioned and
merged:

remote: E: failed to find patch for rev 3abbdb7318018584a27220737bd92081ce8ee67c.
remote: I: patch #186727 updated using rev cc3241a712684f8c7147f5688e9ee3ecb5a93b87.
remote: I: patch #186725 updated using rev 094a63d56fbfb9e23210cc9ac538fb198af37cee.
remote: I: patch #186724 updated using rev ab54bc295cd05281e55bd4d9c37216c0a929fc83.
remote: I: 3 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   f615cb62d4..ab54bc295c  master -> master

- ajax


More information about the xorg-devel mailing list