[PATCH xserver] glamor: Rename var in glamor_xv, SAMPLE is GLSL keyword

Corentin Rossignon corossig at gmail.com
Thu Jan 4 07:37:46 UTC 2018


I am using RadeonSI (mesa) but the real problem is that #version is missing.
I sent a new patch for declaring OpenGL version in glamor xv shader.

2018-01-04 2:11 GMT+01:00 Eric Anholt <eric at anholt.net>:

> Corentin Rossignon <corossig at gmail.com> writes:
>
> > From: Corentin Rossignon <corentin.rossignon at gmail.com>
> >
> > This fix issue with gnome-shell and playing video using xv
> >
> > Signed-off-by: Corentin Rossignon <corentin.rossignon at gmail.com>
> > Bugzilla: https://bugs.freedesktop.org/104405
>
> This is weird -- sample is only a keyword in late versions of GLSL, and
> we shouldn't be requesting a late version of GLSL (#version exists so
> that the language can evolve without breaking old shaders!)  What driver
> was doing this?
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.x.org/archives/xorg-devel/attachments/20180104/d5889ee3/attachment.html>


More information about the xorg-devel mailing list