[PATCH xserver] render: Store and use all 16bpc of precision for solid pixels (v2)

Adam Jackson ajax at nwnk.net
Mon Feb 26 21:52:15 UTC 2018


On Mon, 2018-02-26 at 11:30 -0500, Adam Jackson wrote:
> On Mon, 2018-02-26 at 17:00 +0100, Michel Dänzer wrote:
> > On 2018-02-26 04:33 PM, Adam Jackson wrote:
> > > diff --git a/fb/fbpict.c b/fb/fbpict.c
> > > index 7ea0b668f8..759f0d5db7 100644
> > > --- a/fb/fbpict.c
> > > +++ b/fb/fbpict.c
> > > @@ -220,20 +220,10 @@ static pixman_image_t *
> > >  create_solid_fill_image(PicturePtr pict)
> > >  {
> > >      PictSolidFill *solid = &pict->pSourcePict->solidFill;
> > > -    pixman_color_t color;
> > > -    CARD32 a, r, g, b;
> > > +    /* pixman_color_t and xRenderColor have the same layout */
> > > +    pixman_color_t *color = (pixman_color_t *)&solid->color;
> > 
> > This should be ->fullcolor, shouldn't it?
> 
> Argh, yes. C is just delightful.

Pushed with this fixed:

remote: E: failed to find patch for rev 8171d4c2d67b2990a278dc018ac32534c3afe606.
remote: I: 0 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   9227237806..8171d4c2d6  master -> master

- ajax


More information about the xorg-devel mailing list