[PATCH xserver 1/2] render: Store all 16bpc of precision for solid pictures

Adam Jackson ajax at redhat.com
Mon Feb 26 15:22:52 UTC 2018


On Mon, 2018-02-26 at 12:16 +0100, Michel Dänzer wrote:
> On 2018-02-23 10:08 PM, Adam Jackson wrote:
> > Signed-off-by: Adam Jackson <ajax at redhat.com>
> 
> [...]
> 
> > diff --git a/render/picturestr.h b/render/picturestr.h
> > index 33baef9bf..5d479f18e 100644
> > --- a/render/picturestr.h
> > +++ b/render/picturestr.h
> > @@ -67,7 +67,7 @@ typedef struct pixman_transform PictTransform, *PictTransformPtr;
> >  
> >  typedef struct _PictSolidFill {
> >      unsigned int type;
> > -    CARD32 color;
> > +    xRenderColor color;
> >  } PictSolidFill, *PictSolidFillPtr;
> >  
> >  typedef struct _PictGradientStop {
> > 
> 
> xf86-video-ati's EXA code (and other drivers maybe?) needs to be adapted
> for this. Do you have patches for that?

Hah. Right as I was about to send this out I thought "you know you
don't need to break ABI here, meh, whatever". But yes, this would break
ati intel nouveau qxl and vmware at least. Revised patch to follow.

- ajax


More information about the xorg-devel mailing list