[PATCH xserver 3/3] render: Fix default picture format initialization

[Michel Dänzer]

On 2018-02-24 12:58 AM, Keith Packard wrote:
> Michel Dänzer <michel at daenzer.net> writes:
> 
>> On 2018-02-22 10:53 PM, Adam Jackson wrote:
>>> "depth" for a picture format is the sum of bits of a/r/g/b, and not x.
>>> The default format list was creating an x8r8g8b8 format at depth 32,
>>> which is wrong. Likewise, servers supporting depth 30 would get an
>>> x8r8g8b8 format at depth 30, which is nonsense.
>>
>> Actually, the former isn't wrong, and the latter might not be either, I
>> think. These are the constraints:
>>
>> * The sizes of a/x+r+g+b must equal bpp
>> * The sizes of a+r+g+b must be <= depth (or == ?)
> 
> We could make it ==, but we currently make it <= so that you can have
> r8g8b8 on depth 32, and r4g4b4 on depth 15 and 16.

Those break the first constraint above, is it not valid? So the only
constraint is

 The sizes of a+r+g+b must be <= depth

?

If so, I don't understand what the x component formats are good for...


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer