[PATCH xserver 3/3] render: Fix default picture format initialization

Michel Dänzer michel at daenzer.net
Fri Feb 23 09:51:35 UTC 2018

On 2018-02-22 10:53 PM, Adam Jackson wrote:
> "depth" for a picture format is the sum of bits of a/r/g/b, and not x.
> The default format list was creating an x8r8g8b8 format at depth 32,
> which is wrong. Likewise, servers supporting depth 30 would get an
> x8r8g8b8 format at depth 30, which is nonsense.

Actually, the former isn't wrong, and the latter might not be either, I
think. These are the constraints:

* The sizes of a/x+r+g+b must equal bpp
* The sizes of a+r+g+b must be <= depth (or == ?)

Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

More information about the xorg-devel mailing list