[PATCH xserver] xwayland: Fix backwards need_rotate logic (v2)

Adam Jackson ajax at nwnk.net
Tue Feb 20 18:18:55 UTC 2018


On Tue, 2018-02-20 at 18:48 +0100, Olivier Fourdan wrote:
> Hi,
> 
> On 20 February 2018 at 18:41, Jason Ekstrand <jason at jlekstrand.net> wrote:
> > When xdg_output support was added to Xwayland, need_rotate parameter was
> > added to output_get_new_size where true gave you the old pre-xdg_output
> > behavior and false gave the new behavior.  Unfortunately, the two places
> > where this is called, need_rotate was set backwards.  This caused input
> > get clampped to the wrong dimensions.  Also, the logic for deciding
> > whether or not to flip was wrong because, if need_rotate was false, it
> > would always flip which is not what you want.
> > 
> > v2 (Daniel Stone):
> >  - Fix output_get_new_size so that it doesn't flip the dimensions when
> >    need_rotate is false.
> > 
> > Signed-off-by: Jason Ekstrand <jason at jlekstrand.net>
> > Reviewed-by: Daniel Stone <daniels at collabora.com>
> > Cc: Olivier Fourdan <ofourdan at redhat.com>
> > 
> Hehe, yes, I was typing my reply pointing toward output_get_new_size() as well but you were faster!
> 
> So v2 is:
> 
> Reviewed-by: Olivier Fourdan <ofourdan at redhat.com>

Merged, thanks:

remote: I: patch #205654 updated using rev a054532668cbbb152d0d7acfcce1e03e884bb491.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   343ee7d075..a054532668  master -> master

- ajax


More information about the xorg-devel mailing list