[PATCH xorgproto] randr: MONITORINFO has outputs, not crtcs

Giuseppe Bilotta giuseppe.bilotta at gmail.com
Tue Feb 6 09:48:21 UTC 2018


On Tue, Feb 6, 2018 at 10:03 AM, walter harms <wharms at bfs.de> wrote:
> It would be nice to have an explanation why this change.

The change is to align the description of the protocol with what the
protocol actually sends (see e.g. line 417 in the same file, or the
header and the server source). I would have actually been more verbose
in the commit message if I had known why it was wrong in the first
place (I assume it's some leftover from during the development of the
protocol itself). Shall I respin mentioning this in the commit
message?


> Am 06.02.2018 02:03, schrieb Giuseppe Bilotta:
>> ---
>>  randrproto.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/randrproto.txt b/randrproto.txt
>> index c06bc90..f57301d 100644
>> --- a/randrproto.txt
>> +++ b/randrproto.txt
>> @@ -2363,14 +2363,14 @@ A.1.1 Common Types added in version 1.5 of the protocol
>>       4       ATOM            name
>>       1       BOOL            primary
>>       1       BOOL            automatic
>> -     2       CARD16          ncrtcs
>> +     2       CARD16          noutputs
>>       2       INT16           x
>>       2       INT16           y
>>       2       CARD16          width in pixels
>>       2       CARD16          height in pixels
>>       4       CARD32          width in millimeters
>>       4       CARD32          height in millimeters
>> -     4*n     CRTC            crtcs
>> +     4*n     OUTPUT          outputs
>>  └───
>>
>>  A.2 Protocol Requests
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel



-- 
Giuseppe "Oblomov" Bilotta


More information about the xorg-devel mailing list