[RFC xserver v5 05/14] modesetting: Use atomic modesetting API for pageflip if available

[Adam Jackson]

On Mon, 2017-11-06 at 16:30 -0500, Louis-Francis Ratté-Boulianne wrote:

> +#ifdef GLAMOR_HAS_DRM_ATOMIC
> +    if (ms->atomic_modeset) {
> +        drmModeAtomicReq *req = drmModeAtomicAlloc();
> +
> +        if (!req)
> +            return 1;
> +
> +        ret |= plane_add_prop(req, drmmode_crtc, DRMMODE_PLANE_FB_ID,
> +                              fb_id);
> +        ret |= plane_add_prop(req, drmmode_crtc, DRMMODE_PLANE_CRTC_ID,
> +                              drmmode_crtc->mode_crtc->crtc_id);
> +        ret |= plane_add_prop(req, drmmode_crtc, DRMMODE_PLANE_SRC_X, x);

../hw/xfree86/drivers/modesetting/drmmode_display.c: In function ‘drmmode_crtc_set_fb’:
../hw/xfree86/drivers/modesetting/drmmode_display.c:290:50: error: ‘DRMMODE_PLANE_SRC_X’ undeclared (first use in this function); did you mean ‘DRMMODE_PLANE_CRTC_ID’?
         ret |= plane_add_prop(req, drmmode_crtc, DRMMODE_PLANE_SRC_X, x);
                                                  ^~~~~~~~~~~~~~~~~~~
                                                  DRMMODE_PLANE_CRTC_ID

You don't actually add the define for this until two patches later.
'git rebase -i -x "ninja -C build" master' is a nice way to catch this
kind of problem; if you could refresh your branch with this fixed it'd
be much appreciated.

- ajax