[PATCH xserver 4/7] glx: Use vnd layer for dispatch (v2)

Adam Jackson ajax at redhat.com
Thu Feb 1 21:31:19 UTC 2018

On Wed, 2018-01-10 at 13:57 -0700, Kyle Brenneman wrote:

> xorgGlxThunkRequest should be calling addXIDMap and removeXIDMap, not 
> the internal handlers.

I'm not sure that can be right. If it did, and adding the map failed,
there's no way to get the backend to clean up; at least, not the way
GlxAddXIDMap is currently written. Perhaps that should be changed to
call FreeResource on the XID if AddResource fails? (Like the one place
in the whole server where that'd be correct...)

> The default branch there may need some additional 
> attention if it would handle any requests that create or destroy resources.

It would. The only other vendorpriv extension I know of that does that
is the underspecified and probably unimplementable
GLX_SGIX_video_source though, so it's not really a big deal.

- ajax

More information about the xorg-devel mailing list