[PATCH xkeyboard-config 2/2] evdev/int: Fix KEY_KEYBOARD mapping

Christian Kellner christian at kellner.me
Fri Dec 21 11:19:53 UTC 2018


Hi Hans,

On Fri, 21 Dec, 2018 at 11:21 AM, Hans de Goede <hdegoede at redhat.com> 
wrote:
> KEY_KEYBOARD has an evdev-keycode value of 374 not 366. It seems that
> with the original addition of the mapping the evdev-keycode value was
> mistaken for the X scancode which is 8 higher then the evdev-keycode
> since the X scancodes start at 8. What seems to have happened is that
> the evdev-keycode was used instead of the X scancode and then 8 was
> subtracted for the wrong "// #define KEY_KEYBOARD      366" comment.
Ups. Sorry for that. Your explanation seems very plausible.

> This commit corrects the comment to say 374 and corrects the X
> scancode being mapped to 382.
"#define KEY_KEYBOARD	0x176" is 374 indeed, so looks good to me. Thanks!

Reviewed-by: Christian Kellner <christian at kellner.me>





More information about the xorg-devel mailing list