[PATCH xserver] dix: check_modmap_change() returns Success, not true

[Keith Packard]

Peter Hutterer <peter.hutterer at who-t.net> writes:

> Not sure what if anything calls XSetDeviceModifierMapping() but this would've
> failed all the time. check_modmap_change() returns Successs but we were
> treating it like a boolean. Fix this.

Yeah, and check_modmap_change_slave *does* return a boolean; I see no
possibility for confusion here.

I saw that check_modmap_change returns -1 for BadValue and then checked
to make sure this odd value is fixed up in both
ProcXSetDeviceModifierMapping and ProcSetModifierMapping so that this
value doesn't get back to the client.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20180807/bda22b09/attachment.sig>