[PATCH xserver 1/1] modesetting: Fix GBM objects leak when checking for flip

Louis-Francis Ratté-Boulianne lfrb at collabora.com
Thu Apr 26 15:04:15 UTC 2018


GBM objects were never destroyed after looking for format and
modifier compatibility when deciding whether flipping or copying
a presented pixmap.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106106
Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb at collabora.com>
---
 hw/xfree86/drivers/modesetting/present.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/xfree86/drivers/modesetting/present.c b/hw/xfree86/drivers/modesetting/present.c
index 9be8efe4f..dda7cc064 100644
--- a/hw/xfree86/drivers/modesetting/present.c
+++ b/hw/xfree86/drivers/modesetting/present.c
@@ -263,6 +263,8 @@ ms_present_check_flip(RRCrtcPtr crtc,
 
         format = gbm_bo_get_format(gbm);
         modifier = gbm_bo_get_modifier(gbm);
+        gbm_bo_destroy(gbm);
+
         if (!drmmode_is_format_supported(scrn, format, modifier)) {
             if (reason)
                 *reason = PRESENT_FLIP_REASON_BUFFER_FORMAT;
-- 
2.14.3



More information about the xorg-devel mailing list