[PATCH xserver] vfb: Fix man page in re depth

Alan Coopersmith alan.coopersmith at oracle.com
Mon Apr 23 22:08:09 UTC 2018


On 04/23/18 02:21 PM, Adam Jackson wrote:
> 32 is not a valid depth, and the default is now 24 not 8.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  hw/vfb/man/Xvfb.man | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/hw/vfb/man/Xvfb.man b/hw/vfb/man/Xvfb.man
> index 5fd58eb66a..adfeb8a217 100644
> --- a/hw/vfb/man/Xvfb.man
> +++ b/hw/vfb/man/Xvfb.man
> @@ -55,7 +55,7 @@ manual page, \fIXvfb\fP accepts the following command line switches:
>  .B "\-screen \fIscreennum\fP \fIWxHxD\fP"
>  This option creates screen \fIscreennum\fP and sets its width, height,
>  and depth to W, H, and D respectively.  By default, only screen 0 exists
> -and has the dimensions 1280x1024x8.
> +and has the dimensions 1280x1024x24.
>  .TP 4
>  .B "\-pixdepths \fIlist-of-depths\fP"
>  This option specifies a list of pixmap depths that the server should
> @@ -100,18 +100,18 @@ snapshot can be done with a file copy command, and the resulting
>  snapshot will even contain the cursor image.
>  .SH EXAMPLES
>  .TP 8
> -Xvfb :1 -screen 0 1600x1200x32
> +Xvfb :1 -screen 0 1600x1200x24
>  The server will listen for connections as server number 1, and screen 0
> -will be depth 32 1600x1200.
> +will be depth 24 1600x1200.
>  .TP 8
>  Xvfb :1 -screen 1 1600x1200x16
>  The server will listen for connections as server number 1, will have the

Should that say "screen 0 will have..."

> -default screen configuration (one screen, 1280x1024x8), and screen 1
> +default screen configuration (one screen, 1280x1024x24), and screen 1
>  will be depth 16 1600x1200.
>  .TP 8
>  Xvfb -pixdepths 3 27 -fbdir /var/tmp
>  The server will listen for connections as server number 0, will have the
> -default screen configuration (one screen, 1280x1024x8),
> +default screen configuration (one screen, 1280x1024x24),
>  will also support pixmap
>  depths of 3 and 27,
>  and will use memory mapped files in /var/tmp for the framebuffer.
> 

Other than the above comment, looks good to me.

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>


-- 
	-Alan Coopersmith-               alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - https://blogs.oracle.com/alanc


More information about the xorg-devel mailing list