[ANNOUNCE] xorg-server 1.19.99.904

[Jeff Smith]

On Thu, Apr 12, 2018 at 1:18 AM, Thomas Klausner <wiz at netbsd.org> wrote:
> On Wed, Apr 11, 2018 at 04:24:02PM -0500, Jeff Smith wrote:
>> On Wed, Apr 11, 2018 at 2:44 AM, Thomas Klausner <wiz at netbsd.org> wrote:
>> > I still see this build failure on NetBSD:
>> >
>> > sdksyms.c:1773:15: error: expected expression before ',' token
>> >      (void *) &,                                                  /* ../../dri3/dri3.h:110 */
>> >                ^
>> >
>> >  Thomas
>> >
>>
>> BTW, because of a line-numbering bug in sdksyms.sh, it is misreporting
>> the relevant header line as dri3.h:110,
>> when it should have reported dri3.h:113 (the line declaring
>> drm_format_for_depth).  I'm limited in what I can
>> test at the moment, and haven't been able to reproduce or see a reason
>> why that line would be a problem.
>
> True, there seems to be a line numbering bug:
>
>     (void *) &dri3_screen_init,                                  /* ../../dri3/dri3.h:106 */
>     (void *) &dri3_send_open_reply,                              /* ../../dri3/dri3.h:108 */
>     (void *) &,                                                  /* ../../dri3/dri3.h:110 */
>
> and in dri3/dri3.h:
>
>    106  extern _X_EXPORT Bool
>    107  dri3_screen_init(ScreenPtr screen, const dri3_screen_info_rec *info);
>    108
>    109  extern _X_EXPORT int
>    110  dri3_send_open_reply(ClientPtr client, int fd);
>    111
>    112  extern _X_EXPORT uint32_t
>    113  drm_format_for_depth(uint32_t depth, uint32_t bpp);
>
>> I wonder, is that the only line in sdksyms.c that came out like that,
>> or just the first?
>
> It's the only one.
>  Thomas

Here is something that may help in tracking down the cause of the
disappearing symbol.
1: apply the following changes to sdksyms.sh
2: re-run the build
  (this will output what is being fed into awk from the pre-processor
into sdksyms.i)
3: search for  drm_format_for_depth  in sdksyms.i
  (if not found, search for dri3_send_open_reply instead)
4: post the relevant section of sdksyms.i

-${CPP:-cpp} "$@" sdksyms.c | ${AWK:-awk} -v topdir=$topdir '
+${CPP:-cpp} "$@" sdksyms.c | tee sdksyms.i | ${AWK:-awk} -v topdir=$topdir '

 - Jeff