[PATCH xserver] sdksyms: Skip empty symbols

Thomas Klausner wiz at netbsd.org
Thu Apr 12 06:24:18 UTC 2018


On Wed, Apr 11, 2018 at 03:39:33PM -0400, Adam Jackson wrote:
> Apparently on NetBSD we can hit failures like this:
> 
> sdksyms.c:1773:15: error: expected expression before ',' token
>      (void *) &,                                                  /* ../../dri3/dri3.h:110 */
> 
> I've been unable to reproduce that locally (even in a NetBSD vm), but
> an obvious workaround might be to just notice empty symbol names and
> ignore them rather than emit invalid C code.
> 
> Cc: Thomas Klausner <wiz at netbsd.org>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  hw/xfree86/sdksyms.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

That patch fixes the problem for me, thank you!

I had another local change to the file, it doesn't look related but
perhaps it is; full patch attached.

Looking at the package, I have more changes that are not integrated,
I'll prepare a changeset later.

Thanks,
 Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-hw_xfree86_sdksyms.sh
Type: application/x-sh
Size: 1244 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20180412/3ebffefb/attachment-0001.sh>


More information about the xorg-devel mailing list