[PATCH xserver v3 3/3] modesetting: Actually get framebuffer ID

[Olivier Fourdan]

On 5 April 2018 at 17:47, Daniel Stone <daniels at collabora.com> wrote:

> We would fail to get the FB ID if it wasn't already imported, since we
> were checking to see if the pointer was NULL (it never was) rather than
> if the content of the pointer was 0.
>
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> Reported-by: Olivier Fourdan <ofourdan at redhat.com>
> ---
>  hw/xfree86/drivers/modesetting/drmmode_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c
> b/hw/xfree86/drivers/modesetting/drmmode_display.c
> index cdcd4f3f3..322ef050b 100644
> --- a/hw/xfree86/drivers/modesetting/drmmode_display.c
> +++ b/hw/xfree86/drivers/modesetting/drmmode_display.c
> @@ -624,7 +624,7 @@ drmmode_crtc_get_fb_id(xf86CrtcPtr crtc, uint32_t
> *fb_id, int *x, int *y)
>          *y = crtc->y;
>      }
>
> -    if (fb_id == 0) {
> +    if (*fb_id == 0) {
>          ret = drmmode_bo_import(drmmode, &drmmode->front_bo,
>                                  &drmmode->fb_id);
>          if (ret < 0) {
> --
> 2.16.3
>
>

LGTM, Thanks!

Tested-by: Olivier Fourdan <ofourdan at redhat.com>
Reviewed-by: Olivier Fourdan <ofourdan at redhat.com>

Cheers,
O.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.x.org/archives/xorg-devel/attachments/20180405/915cb15e/attachment.html>