[PATCH xserver 01/15] dri3: annotate the dri3_screen_info data as const

Emil Velikov emil.l.velikov at gmail.com
Wed Apr 4 11:07:52 UTC 2018


On 2 April 2018 at 20:34, Adam Jackson <ajax at redhat.com> wrote:
> On Mon, 2018-04-02 at 16:41 +0100, Emil Velikov wrote:
>
>> Why do we have the explicit _rec and _ptr typecasts to begin with?
>
> Convention, mostly. The typedef for the struct is because 'struct' is a
> dumb word to need to say all the time. The typedef for the pointer is
> vaguely distasteful and I've been trying to stop.
>
s/dumb/annoying/

Using _t suffix over _rec seems more indicative IMHO.
Regardless, most of the series is a must have for 1.20 - if you want
to give it a skim that'll be appreciated.

Thanks
Emil


More information about the xorg-devel mailing list