[PATCH xserver] xfree86: Hush some warnings when Xv is disabled

Eric Anholt eric at anholt.net
Mon Sep 25 20:06:51 UTC 2017


Adam Jackson <ajax at redhat.com> writes:

> Spotted by Appveyor:
>
> xf86Crtc.c:3281:1: warning: ‘xf86_crtc_box_area’ defined but not used [-Wunused-function]
>  xf86_crtc_box_area(BoxPtr box)
>  ^~~~~~~~~~~~~~~~~~
> xf86Crtc.c:3268:1: warning: ‘x86_crtc_box’ defined but not used [-Wunused-function]
>  x86_crtc_box(xf86CrtcPtr crtc, BoxPtr crtc_box)
>  ^~~~~~~~~~~~
> xf86Crtc.c:3256:1: warning: ‘x86_crtc_box_intersect’ defined but not used [-Wunused-function]
>  x86_crtc_box_intersect(BoxPtr dest, BoxPtr a, BoxPtr b)
>  ^~~~~~~~~~~~~~~~~~~~~~

Mesa has started using their _X_UNUSED equivalent for stuff like this,
so that things are compiled either way but DCEed without complaint when
the caller is disabled.  However, this is also a correct cleanup, so:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170925/c57b4673/attachment.sig>


More information about the xorg-devel mailing list