[PATCH xserver] meson: Make it possible to build for 32-bit targets

Alexander E. Patrakov patrakov at gmail.com
Sat Sep 23 14:16:12 UTC 2017


2017-09-22 17:54 GMT+05:00 Jon Turney <jon.turney at dronecode.org.uk>:
> Setting glx_align64 to '' gives a null string in the arguments list passed
> to the compiler.  This is taken as an input filename, leading to:
>
> "cc: error: : No such file or directory"
>
> Instead, assign an empty list to glx_align64, which gets flattened to
> nothing in the arguments list.
>
> Signed-off-by: Jon Turney <jon.turney at dronecode.org.uk>
> ---
>  include/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/meson.build b/include/meson.build
> index 05ef76930..a772d565f 100644
> --- a/include/meson.build
> +++ b/include/meson.build
> @@ -31,7 +31,7 @@ else
>      conf_data.set('X_BYTE_ORDER', 'X_BIG_ENDIAN')
>  endif
>
> -glx_align64 = ''
> +glx_align64 = []
>  if cc.sizeof('unsigned long') == 8
>     conf_data.set('_XSERVER64', '1')
>     glx_align64 = '-D__GLX_ALIGN64'

Just cosmetics.

You are replacing an empty list with a string. Does it work to replace
an empty list with a list with one element, instead, so that the
glx_align64 variable is always a list?

-- 
Alexander E. Patrakov


More information about the xorg-devel mailing list