Re:?==?utf-8?q? [RFC xserver 06/12] present: Check the whole exec queue on event

Louis-Francis Ratté-Boulianne louis-francis.ratte-boulianne at collabora.co.uk
Wed Sep 20 19:24:57 UTC 2017


Hi,
 
On Wednesday, August 30, 2017 03:19 EDT, Michel Dänzer <michel at daenzer.net> wrote: 
 
> On 30/08/17 02:16 PM, Louis-Francis Ratté-Boulianne wrote:
> > Later events are sometimes added in front of the queue (e.g.
> > if page flipping fails) so we need to check the whole queue
> > on event.
> > 
> Hmm, I guess this can happen if present_flip() fails in
> present_execute()? Do you have a reproducible way to trigger a problem
> without this change?

I was able to reproduce the problem because at some point I broke page flipping while rebasing.

> Should the same code in present_abort_vblank() be removed as well?

Indeed, thanks!

--
Louis-Francis



More information about the xorg-devel mailing list