[PATCH xserver 2/2] glx: Fix visual fbconfig matching with respect to swap method

[Adam Jackson]

On Wed, 2017-09-06 at 16:27 +0200, Thomas Hellstrom wrote:
> For the built in visuals, we'd typically select the "best" fbconfig
> without considering the swap method. If the client then requests a
> specific swap method, say GLX_SWAP_COPY_OML, it may well happen that the
> first fbconfig matching requirements would have been paired with the 32-bit
> compositing visual, and the client would render a potentially transparent
> window.
> 
> Fix this so that we try to match fbconfigs with the same swap method to all
> built-in visuals. That would guarantee that selecting a specific swap-
> method would not influence the chance of getting a compositing visual.

Putting the swap method in the fbconfig was such a bizarre idea. 

This does sort of mean an application needs to select by fbconfig
instead of by visual if it explicitly wants exchanges or copies. But
undefined swaps are certainly going to be most performant in general,
so I suppose I'd rather see this than explode the visual list by
another factor of two or three.

Merged this series, thanks:

remote: I: patch #175415 updated using rev 0fc26310d5b09213c65f50bde444a1758172b016.
remote: I: patch #175432 updated using rev 4486d199bd3bcb5b2b8ad9bc54eb11604d9bd653.
remote: I: 2 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   da29a15874..4486d199bd  master -> master

- ajax