[PATCH libpciaccess] linux: support 32 bit PCI domains (v2)

Eric Anholt eric at anholt.net
Fri Sep 8 18:21:39 UTC 2017


Adam Jackson <ajax at redhat.com> writes:

> From: Stephen Hemminger <stephen at networkplumber.org>
>
> The PCI domain may be larger than 16 bits on Microsoft Azure and other
> virtual environments. PCI busses reported by ACPI are limited to 16
> bits, but in Azure the domain value for pass through devices is
> intentionally larger than 16 bits to avoid clashing with local devices.
> This is needed to support pass through of GPU devices.
>
> v2: (ajax)
> Rename fields as domain_{16,32} to force consumers to adapt when built
> against the new library. Update FreeBSD and Solaris backends to preserve
> the full 32-bit domain number, since on those OSes it stands a chance of
> working already. Update NetBSD and OpenBSD backends to initialize
> domain_16 compatibly with older libpciaccess; neither backend appears to
> support more than a handful of domains to begin with though. Trivially
> update the generic x86 backend for source compatibility, though it still
> only supports one domain and will never be better.

I like extending of the struct and keeping the old field around, but
breaking source compatibility seems like unnecessary pain to me.  Could
we keep the first field "domain_16" and name the new one "domain"?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170908/d3bdfbe3/attachment.sig>


More information about the xorg-devel mailing list