[PATCH libICE 03/13] save one indentlevel in IceProtocolSetup

Emil Velikov emil.l.velikov at gmail.com
Tue Oct 31 13:23:16 UTC 2017


On 18 October 2017 at 16:53, walter harms <wharms at bfs.de> wrote:
>
>
> save one indentlevel in IceProtocolSetup by early check and
> remove a lost free() check
> Signed-off-by: Walter Harms <wharms at bfs.de>
>
Thanks for the poke Walter.
Patches 1 + 2 were applied back in Sept and having similar patches got
me confused a bit ;-)

> @@ -235,53 +236,49 @@ IceProtocolSetup (
>                 free (reply.protocol_error.error_message);
>             }
>
> -           if (iceConn->protosetup_to_you->my_auth_indices)
> -               free (iceConn->protosetup_to_you->my_auth_indices);
> +
Unnecessary newline.

> +           free (iceConn->protosetup_to_you->my_auth_indices);
For posterity - can you please split this out?

Thanks
Emil


More information about the xorg-devel mailing list