[PATCH xserver 1/4] modesetting: Fix potential buffer overflow

Adam Jackson ajax at nwnk.net
Mon Oct 30 17:50:16 UTC 2017


On Mon, 2017-10-30 at 09:51 +0000, Eric Engestrom wrote:
> On Friday, 2017-10-27 16:11:53 +0200, Daniel Martin wrote:
> > If one misconfigures a ZaphodHeads value (more than 20 characters
> > without a delimiter), we get an overflow of our buffer.
> > Use xstrtokenize() instead of writing/fixing our own tokenizer.
> > 
> > Signed-off-by: Daniel Martin <consume.noise at gmail.com>
> 
> Patches 1-3 are
> Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
> 
> Patch 4 is
> Acked-by: Eric Engestrom <eric.engestrom at imgtec.com>

1/4 didn't want to link for me until I added _X_EXPORT to the
xstrtokenize declaration, and 4/4 had some build failures on Windows
and OSX in some of the non-server utility apps (hooray for CI that can
test these things for me). Fixed those issues and merged:

remote: E: failed to find patch for rev 04a305121fbc08ecc2ef345ee7155d6087a43fd1.
remote: I: patch #185076 updated using rev 0bcc65f2bf479c6a74ac70bb5b5181d6834dded6.
remote: I: patch #185077 updated using rev 15a32ee5d1fffa171bb05af9a0e5b472e4af1488.
remote: E: failed to find patch for rev d5379b350fb63e42e604361c21ad9832b4c791b9.
remote: I: 2 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   2230e6c8af..d5379b350f  master -> master

- ajax


More information about the xorg-devel mailing list