[PATCH xserver] xf86-video-modesetting: Fix ms_queue_vblank(flags = MS_QUEUE_RELATIVE)

Keith Packard keithp at keithp.com
Fri Oct 27 03:51:50 UTC 2017


Alex Goins <agoins at nvidia.com> writes:

> Adding Keith, as this is a regression that completely breaks PRIME Sync configs
> at top of tree.

Adam asked me to look at this last week, and I'm afraid I've not had a
chance as I've been traveling. Thanks for the reminder. Reading through
the original patch, I agree that the new ms_queue_vblank function fails
to treat the relative sequence case correctly. And your fix does present
the correct information to the kernel.

Your patch also highlights a further bug in this code -- the call to
ms_drm_abort_seq is passing 'msc' instead of 'seq'. That only happens in
an error case, which probably means approximately never.

For your patch:

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20171026/8bc6c560/attachment.sig>


More information about the xorg-devel mailing list