[PATCH xserver] present: Only send PresentCompleteNotify events to the presenting client

[Michel Dänzer]

On 20/10/17 09:58 PM, Keith Packard wrote:
> Michel Dänzer <michel at daenzer.net> writes:
> 
>> From: Michel Dänzer <michel.daenzer at amd.com>
>>
>> We were sending the events to all clients listening for them on the
>> window. But clients can get confused by events from another client, and
>> I can't imagine any case where reciving events from other clients would
>> be required.
> 
> While I agree that it's unlikely to be useful to send the event to all
> listening clients, there is a 'PRESENTEVENTID' in the CompleteNotify
> which clients "should" be using to check to see if the event being
> delivered is the one associated with their action.
> 
> Did we mess up in some client library and not do this? If so, we might
> want to fix that library?

Looking at the Mesa code, it uses xcb_generate_id to generate the event
ID. AFAICT the XCB code is properly checking and only queuing special
events with a matching event ID, so the only possible explanation seems
that xcb_generate_id ends up generating the same ID for multiple
clients. Is that plausible?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 224 bytes
Desc: OpenPGP digital signature
URL: <https://lists.x.org/archives/xorg-devel/attachments/20171023/3f029de7/attachment.sig>