[RFC v2 03/12] sync: Move fence destroy call to object specific function

[Adam Jackson]

On Wed, 2017-09-27 at 01:19 -0400, Louis-Francis Ratté-Boulianne wrote:

> @@ -41,11 +41,10 @@ miSyncScreenCreateFence(ScreenPtr pScreen,
> SyncFence * pFence,
>      pFence->triggered = initially_triggered;
>  }
>  
> -void
> -miSyncScreenDestroyFence(ScreenPtr pScreen, SyncFence * pFence)
> +int
> +miSyncGetFenceType(SyncFence *pFence)
>  {
> -    (void) pScreen;
> -    (void) pFence;
> +    return pFence->type;
>  }

This function is not referenced in this commit, even the header decl
isn't present until 4/12. Since this function appears to be unrelated
to the this refactor it should probably be moved into 4/12. (But my
comments on 4/12 itself may make this point moot.)

> @@ -94,7 +101,8 @@ miSyncInitFence(ScreenPtr pScreen, SyncFence *
> pFence, Bool initially_triggered)
>          &miSyncFenceReset,
>          &miSyncFenceCheckTriggered,
>          &miSyncFenceAddTrigger,
> -        &miSyncFenceDeleteTrigger
> +        &miSyncFenceDeleteTrigger,
> +        &miSyncFenceDestroy
>      };
>  
>      pFence->pScreen = pScreen;

Please use a , even on the last item in a list (yes even though the
original code didn't, it should have).

- ajax