[PATCH xserver 0/4] meson: Fix DEBUG definition

Adam Jackson ajax at nwnk.net
Fri Oct 20 17:17:13 UTC 2017


On Fri, 2017-10-13 at 15:44 -0400, Lyude Paul wrote:
> At the moment, meson makes the mistake of never defining the DEBUG
> macro, regardless of the current build type. Unfortunately, just
> enabling that definition by default for debug builds brought up a good
> number of compiler warnings and errors from other files that were being
> silenced due to that.
> 
> This series makes it so meson defines DEBUG when the buildtype is debug,
> while additionally also fixing all of the compiler warnings/errors this
> causes in the default configuration.
> 
> Lyude Paul (4):
>   fbdevhw: Fix inconsistent #if DEBUG usage
>   x86emu: Fix type conversion warnings on x86_64 with DEBUG
>   meson: Silence -Wformat-nonliteral for x86emu
>   meson: Don't forget to define DEBUG!
> 
>  hw/xfree86/fbdevhw/fbdevhw.c     |  6 +++---
>  hw/xfree86/int10/meson.build     |  6 ++++++
>  hw/xfree86/x86emu/sys.c          | 12 ++++++------
>  hw/xfree86/x86emu/x86emu/types.h |  1 +
>  include/meson.build              |  4 +++-
>  5 files changed, 19 insertions(+), 10 deletions(-)

Merged, thanks:

remote: I: patch #182583 updated using rev 01470ce0a9628abc8af4fe7b960f0d1eced8cd46.
remote: I: patch #182585 updated using rev cbca18c5516084ee540255df52e116209f1c1cbe.
remote: I: patch #182584 updated using rev 0debe011901b87f686e2a76ce5edc150b04bf9d1.
remote: I: patch #182586 updated using rev 6d7e1d1de06336c9b49a253810afda8ac4e9f7b2.
remote: I: 4 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   c66d65a645..6d7e1d1de0  master -> master

- ajax


More information about the xorg-devel mailing list