[PATCH] XShmGetImage: fix censoring

Adam Jackson ajax at redhat.com
Thu Oct 12 19:59:14 UTC 2017

On Wed, 2017-10-11 at 21:56 -0400, Nikolay Martynov wrote:
> Hi.
> One more kind ping on this. It has been sent quite a long time ago
> without any reply. It would really appreciate if someone could let me
> know if this is a correct mailing list or not?

Thanks for your patience, this looks good. Or at least, it looks
better; the code is still kind of wrong, in that it's fetching the
image and _then_ censoring, but since the destination is shared memory
a client could potentially win the race and get some bits out that it
shouldn't. And we're doing this censorship unilaterally, which seems
like excess work if the windows clipping the one we're GetImage'ing
from belong to the same client.

Still, better than before, merged, thanks!

- ajax

More information about the xorg-devel mailing list