[PATCH xserver] meson: Don't forget to define DEBUG!

Adam Jackson ajax at nwnk.net
Thu Oct 12 19:20:39 UTC 2017


On Wed, 2017-10-11 at 19:15 -0400, Lyude Paul wrote:
> Signed-off-by: Lyude Paul <lyude at redhat.com>

Nak. One, because debugoptimized appears to be the default build type,
and I'm not really convinced it makes sense to enable all the random
debugging bits in the normal case, at least not without putting in some
effort to rationalize the existing "debug" code. (grep for DebugF() and
see just how arbitrary things are.)

But also two because it breaks the build:

../hw/xfree86/fbdevhw/fbdevhw.c:123:10: error: #if with no expression
 #if DEBUG
          ^
../hw/xfree86/fbdevhw/fbdevhw.c: In function ‘fbdevHWSetMode’:
../hw/xfree86/fbdevhw/fbdevhw.c:469:10: error: #if with no expression
 #if DEBUG
          ^
../hw/xfree86/fbdevhw/fbdevhw.c:489:10: error: #if with no expression
 #if DEBUG
          ^

- ajax


More information about the xorg-devel mailing list