[PATCH xserver] meson: Add xkb_bin_dir option

[Adam Jackson]

On Thu, 2017-10-12 at 09:35 +0100, Daniel Stone wrote:
> Hi,
> 
> On 11 October 2017 at 23:03, Lyude Paul <lyude at redhat.com> wrote:
> > Now that we can actually configure all of the directories xkb uses for
> > finding things, we can (finally, but only with meson) finally make it so
> > that with the correct meson configuration the Xserver will "just work"
> > without any additional changes to the installation prefix after
> > building.
> > 
> > For the people like me who have since scripted this part out of their
> > build process and forgotten about it, building and installing the X
> > server into a non-standard prefix has always required the following (or
> > something else that makes sure that X has a valid xkbcomp configuration)
> > commands be run right after doing the installation:
> > 
> >         # start in root of prefix you installed X to
> >         mkdir -pv share/X11/xkb/rules
> >         ln -s /usr/share/X11/xkb/rules/evdev share/X11/xkb/rules/
> >         rm -f bin/xkbcomp
> >         ln -s /usr/bin/xkbcomp bin/
> > 
> > The one last piece of getting rid of this post-install junk is making
> > sure that we can control the directory that X uses for finding the
> > xkbcomp binary from meson so we can point it at the system provided
> > xkbcomp (/usr/bin/xkbcomp or similar). So, this patch adds a
> > configuration option for controlling this called xkb_bin_dir.
> 
> We really should've made xkbcomp ship a pkg-config file.

Should have?

https://cgit.freedesktop.org/xorg/app/xkbcomp/tree/xkbcomp.pc.in

> Reviewed-by: Daniel Stone <daniels at collabora.com>

remote: I: patch #181929 updated using rev 10cba7d54668698741510374ee63dec7a3cc3647.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   b747da5e25..10cba7d546  master -> master

- ajax