[PATCH xserver 01/11] xfree86: Fix set but not used warnings in lnx_platform

[Daniel Martin]

On 7 November 2017 at 13:57, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 7 November 2017 at 09:38, Daniel Martin <consume.noise at gmail.com> wrote:
>> ../hw/xfree86/os-support/linux/lnx_platform.c: In function ‘get_drm_info’:
>> ../hw/xfree86/os-support/linux/lnx_platform.c:29:16: warning: variable ‘minor’ set but not used [-Wunused-but-set-variable]
>>      int major, minor, fd;
>>                 ^~~~~
>> ../hw/xfree86/os-support/linux/lnx_platform.c:29:9: warning: variable ‘major’ set but not used [-Wunused-but-set-variable]
>>      int major, minor, fd;
>>          ^~~~~
>>
> It's not immediately obvious so I'd add some meat to the commit message.
>
> "When building w/o systemd, the functions ... are macros which don't
> use the A/B arguments.
> This leads to the following build warning:
>
> .... warning messages ...
> "
>
> With that
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks, I've added the comments.