[PATCH xserver 00/11] modesetting: Fixes, cleanups and mode_output removal

Daniel Martin consume.noise at gmail.com
Tue Nov 7 09:38:31 UTC 2017


Hi all,

I've written a few fixes and patches to rip out the mode_output member.
We don't need it, we just fail handling it.

- fixing a compiler warning:

  xfree86: Fix set but not used warnings in lnx_platform

- small fix (log msg missed a new-line):

  modesetting: Fix log msg if pixmap creation failed

- output name creation looked scary to me:

  modesetting: Simplify mst path blob parsing
  modesetting: Simplify output name creation

! Yet another place where we fail to properly handle the output_id vs.
  mode_output members:

  modesetting: Reset output_id if drmModeGetConnector failed

! The previous fix was the final motivation for the following patches.
  Remove the mode_output member! I made it in small chunks for an easier
  review. Though, imho, they could be squashed together.

  modesetting: Save number of encoders in drmmode_output
  modesetting: Retrieve drm connector in drmmode_output_get_modes()
  modesetting: Retrieve drm connector in
    drmmode_output_create_resources()
  modesetting: Retrieve drm connector in drmmode_output_detect()
  modesetting: Remove mode_output member from drmmode_output

- micro optimization:

  modesetting: Get current connector infos in drmmode_output_init()

 hw/xfree86/drivers/modesetting/drmmode_display.c | 192 +++++++++++------------
 hw/xfree86/drivers/modesetting/drmmode_display.h |   2 +-
 hw/xfree86/os-support/linux/lnx_platform.c       |   9 +-
 3 files changed, 95 insertions(+), 108 deletions(-)


Have a nice day,
    Daniel Martin


More information about the xorg-devel mailing list