[PATCH xserver 8/8] glamor: Eliminate EGL stubs

[Emil Velikov]

Hi Adam,

Above all - hell yea...
No more ugly wrappers and build magic :-)

On 1 November 2017 at 20:31, Adam Jackson <ajax at redhat.com> wrote:
> glamor_init is now spelled glamor_api_init, and takes as a new parameter
> the winsys API initialization function. A compatibility function is
> added for radeon's sake since it's using glamor_init currently; it only
> works for EGL, which is fine since Xephyr doesn't need it.
>
I cannot see a compat glamor_init() in the pathes. Did you forget to
git add, or you've added that to the radeon/amdgpu driver instead?
If the latter one should be able to drop the macro
GLAMOR_USE_EGL_SCREEN all together.

There's a couple of glamor_init instances remaining.
$sed -i "s/glamor_init/glamor_api_init/g" glamor/glamor.[ch]


> glamor_*_from_pixmap are moved to glamor/glamor_egl.c (i.e. the xfree86
> code). This is legitimate because glamor_egl_dri3_fd_name_from_tex was a
> stub in Xwayland anyway.
>
Seems like glamor_*_from_pixmap should really by glamor_egl_*_from_pixmap.
Just asking - I don't know if it's worth renaming it at this point.

-Emil