[PATCH] glx: Duplicate relevant fbconfigs for compositing visuals

[Thomas Hellstrom]

Ping?

It would be good to resolve this.

Thomas


On 10/13/2017 07:43 AM, Thomas Hellstrom wrote:
> Hi,
>
> On 10/12/2017 10:32 PM, Adam Jackson wrote:
>> On Thu, 2017-10-12 at 15:06 +0200, Thomas Hellstrom wrote:
>>> Ping?
>> If we're going to do this, and I guess we have to, I'd like to see two
>> changes:
>>
>> 1) Don't duplicate single-buffered fbconfigs
>
> OK. I was trying to figure out what Nvidia was doing here, and they 
> appear to expose
> both single-buffer and sRGB 32-bit visuals.
>
>> 2) Point all these fbconfigs at the same visual
>
> The problem with doing that is that the glx visual pointed to by the 
> fbconfig might have completely
> different glx traits compared to the original fbconfig. I'm not sure 
> whether that will cause any
> problems but I guess it might be confusing. Again, looking at what 
> Nvidia does, they expose a
> number of 32-bit fbconfigs.
>
> The follow-up RFC patch tries to reduce the number of identical GLX 
> visuals, though.
>
> Let me know whether you think we should go the nvidia way or try to 
> expose as little as possible.
>
> Another question that has surfaced is the criterion we use to 
> determine whether a visual should be compositing or not.
> In the patch I've considered 32-bit visuals as compositing. But 
> looking at older dri1 client side code, it considers all
> visuals with depth != DefaultDepth(dpy, screen) as compositing.
>
> Thanks,
> Thomas
>
>
>>
>> - ajax
>
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: 
> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.x.org_archives_xorg-2Ddevel&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=wnSlgOCqfpNS4d02vP68_E9q2BNMCwfD2OZ_6dCFVQQ&m=rTS6zD-6oERXwv8y1IjajpiurcZYX4BaUqsLz6WLEPY&s=WoheJ88yz-rvTckzoMyOcMHBm4LO0piRj1Sn9iL1H-0&e=
> Info: 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.x.org_mailman_listinfo_xorg-2Ddevel&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=wnSlgOCqfpNS4d02vP68_E9q2BNMCwfD2OZ_6dCFVQQ&m=rTS6zD-6oERXwv8y1IjajpiurcZYX4BaUqsLz6WLEPY&s=YkM9sRc-zGrIVqjwg3k9eAHokvwCSCVbeiAE4mX2O5Y&e=