[PATCH xkeyboard-config] Add evdev mappings for KEY_SOUND, KEY_UWB, KEY_WWAN and KEY_RFKILL

Hans de Goede hdegoede at redhat.com
Mon May 15 17:13:16 UTC 2017


Hi,

On 15-05-17 16:59, Sergey Udaltsov wrote:
> Hi Hans
> 
> I can push, of course, if the mutual consensus is that now is the right time for it.

I consider the patch ready for merging / pushing, which is why I tried to push it
myself :)

Regards,

Hans

> On Mon, May 15, 2017 at 8:26 AM, Hans de Goede <hdegoede at redhat.com <mailto:hdegoede at redhat.com>> wrote:
> 
>     Hi,
> 
>     On 15-05-17 03:06, Peter Hutterer wrote:
> 
>         adding svu to CC:
> 
>         On Fri, May 12, 2017 at 04:18:42PM +0200, Hans de Goede wrote:
> 
>             KEY_SOUND, KEY_WWAN and KEY_RFKILL are used on actual devices and
>             current xproto master defines keysyms for these. Add mappings for
>             these keys.
> 
>             The XF86UWB keysm exists for quite a while now, as does the KEY_SOUND
>             evdev code for it, so lets adds a mapping for that too.
> 
>             Note that this replaces the I255 to XF86Hibernate mapping in
>             xkb_symbols "evdev", I don't know where that came from, but it is
>             wrong, I255 was until now not defined in keycodes/evdev and
>             KEY_HIBERNATE is not defined in linux/input-event-codes.h .
> 
> 
>         see xk-c commit 7b3bfb3ec4b, has a link to the thread. After a bit of
>         digging, this got merged into dmitry's next tree (see
>         https://patchwork.kernel.org/patch/9742/ <https://patchwork.kernel.org/patch/9742/>) but never ended up in master.
>         My email archives trail out from there and I'm not sure what exactly
>         happens, google isn't forthcoming either.
> 
>         Looks like we simply pushed the xk-c patch too early, assumign that -next
>         will end up in master. But anyway, we've survived 8 years without it, so I
>         think we're good :)
> 
> 
>     Thank you for the digging I've updated the commit message to reflect
>     this info and correct the grammar errors Bastien pointed out. I've
>     tried to push this, but it just hangs ? Maybe because I don't have
>     write access to xkeyboard-config (it is sitting outside of the
>     xorg tree after all) ?
> 
>     Anyways I'll send a v2 with the improved commit message, if you can push
>     that, that would be great.
> 
>     Regards,
> 
>     Hans
> 
> 


More information about the xorg-devel mailing list