[PATCH xproto v2 1/2] Add XF86XK_WWAN and XF86XK_Rfkill

[Peter Hutterer]

On Wed, May 10, 2017 at 05:53:53PM +0200, Hans de Goede wrote:
> Add Keysyms corresponding to the evdev WWAN and RFKILL keys, we already
> have Keysyms for WLAN and UWB from linux/input-event-codes.h:
> 
>  #define KEY_WLAN                238
>  #define KEY_UWB                 239
> 
> But not for the WWAN and generic RFKILL keys:
> 
>  #define KEY_WWAN                246     /* Wireless WAN (LTE, UMTS, GSM, etc.) */
>  #define KEY_WIMAX               KEY_WWAN
>  #define KEY_RFKILL              247     /* Key that controls all radios */
> 
> This commits add Keysyms for these so that we can add proper mappings for
> them to xkb.
> 
> Cc: Bastien Nocera <bnocera at redhat.com>
> Cc: Benjamin Berg <bberg at redhat.com>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
> Changes in v2:
> -Define XF86XK_WWAN instead of XF86XK_WiMAX, as KEY_WIMAX is an alias
>  for KEY_WWAN, I intended to do this for v1 before submitting, but I forgot

>  XF86keysym.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/XF86keysym.h b/XF86keysym.h
> index 89d40b8..b04d45e 100644
> --- a/XF86keysym.h
> +++ b/XF86keysym.h
> @@ -199,6 +199,9 @@
>  
>  #define XF86XK_Keyboard		0x1008FFB3   /* User defined keyboard related action */
>  
> +#define XF86XK_WWAN		0x1008FFB4   /* Toggle WWAN (LTE, UMTS, etc.) radio */
> +#define XF86XK_Rfkill		0x1008FFB5   /* Toggle radios on/off */

Only comment I have: Rfkill seems odd because RF is an abbreviation, so I'd
go with RFKill. See also the capitalisation on Switch_VT, rather than Switch_Vt.

With that change, Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
or without it too, if you think Rfkill is better :)

Cheers,
   Peter

> ---
> +
>  /* Keys for special action keys (hot keys) */
>  /* Virtual terminals on some operating systems */
>  #define XF86XK_Switch_VT_1	0x1008FE01
> -- 
> 2.12.2