[PATCH xserver v2] edid: Prune duplicates after adding modes from DDC

Emil Velikov emil.l.velikov at gmail.com
Tue Mar 21 15:07:14 UTC 2017


On 9 March 2017 at 08:34, Michel Dänzer <michel at daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> Multiple calls to xf86EdidMonitorSet (which can be triggered e.g. by
> running xrandr) would potentially keep adding the same modes, causing
> the Monitor->Modes list to keep growing larger and using up more memory.
>
> Fix this by calling xf86PruneDuplicateModes after adding the modes
> returned by xf86DDCGetModes. This makes sure there's only one instance
> of each unique mode in the list.
>
> v2:
> * Replace semicolon with {} for empty for loop (Emil Velikov)
> * Slightly tweak commit log to avoid minor inaccuracy about what
>   xf86PruneDuplicateModes does
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99521
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

Patch looks spot on. Fwiw
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

-Emil


More information about the xorg-devel mailing list