[PATCH xserver] glamor: Fix dashed line rendering.

Michel Dänzer michel at daenzer.net
Thu Mar 16 02:18:25 UTC 2017


On 16/03/17 10:24 AM, Eric Anholt wrote:
> We were binding the screen pixmap as the dash and sampling its alpha,
> which is usually just 1.0 (no dashing at all).
> 
> Please cherry-pick this to active stable branches.
> 
> Signed-off-by: Eric Anholt <eric at anholt.net>
> ---
>  glamor/glamor_dash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/glamor/glamor_dash.c b/glamor/glamor_dash.c
> index 3c19dba323c7..f3cf749a6785 100644
> --- a/glamor/glamor_dash.c
> +++ b/glamor/glamor_dash.c
> @@ -146,7 +146,7 @@ glamor_dash_setup(DrawablePtr drawable, GCPtr gc)
>          goto bail;
>  
>      dash_pixmap = glamor_get_dash_pixmap(gc);
> -    dash_priv = glamor_get_pixmap_private(pixmap);
> +    dash_priv = glamor_get_pixmap_private(dash_pixmap);
>  
>      if (!GLAMOR_PIXMAP_PRIV_HAS_FBO(dash_priv))
>          goto bail;
> 

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the xorg-devel mailing list