[PATCH xserver] Revert "prime: Sync shared pixmap from root window instead of screen pixmap"

Adam Jackson ajax at nwnk.net
Fri Mar 10 16:15:46 UTC 2017


On Fri, 2017-03-10 at 11:40 +0900, Michel Dänzer wrote:
> On 09/03/17 08:25 PM, Chris Wilson wrote:
> > This reverts commit b5b292896f647c85f03f53b20b2f03c0e94de428.
> > 
> > This breaks the concept of the screen->pixmap_dirty_list as it no longer
> > tracks the relationship between the PixmapDirtyUpdate src and slave_dst,
> > for the supposed convenience of not tracking present flips.
> 
> Bugzilla: https://bugs.freedesktop.org/100086
> 
> 
> I agree with reverting this on the 1.19 branch, sorry for jumping the
> gun there (I guess I was expecting all drivers to just use
> PixmapSyncDirtyHelper, but of course there's no requirement for that).
> Note that 5c1dd4eba833 ("present: Allow flipping with PRIME slave
> outputs") needs to be reverted first, and then I'd suggest cherry
> picking bb9128fdc86d ("present: disable page flip only when a slave crtc
> is active") to 1.19 instead.

Done, with a fixup to keep dmx building:

To ssh://git.freedesktop.org/git/xorg/xserver
   f23e65f..db1326c  server-1.19-branch -> server-1.19-branch

- ajax


More information about the xorg-devel mailing list