[PATCH xserver] sdksyms: Tighten up the symbols we add to the magic table

Adam Jackson ajax at nwnk.net
Mon Mar 6 22:20:34 UTC 2017


On Mon, 2017-03-06 at 18:23 +0000, Jon Turney wrote:

> Unfortunately, one of the possible definitions of _X_EXPORT in 
> Xfuncproto.h is empty, in which case, this leaves us with nothing in 
> sdksyms.c

Though this be true, I'm not sure how it can matter. We only build
xfree86 on systems where _X_EXPORT expands to something non-empty. And
we rely on it expanding to something non-empty because we build the
rest of the server with hidden visibility, so we need a positive way to
declare that a symbol is exported; if the system does not have this
facility, then the server isn't going to export the correct set of
symbols to the drivers anyway.

- ajax


More information about the xorg-devel mailing list