[RFC dri3proto 01/16] Add modifier/multi-plane requests, bump to v1.1

[Daniel Stone]

On 13 June 2017 at 21:43, Adam Jackson <ajax at nwnk.net> wrote:
> On Thu, 2017-06-08 at 19:43 +0100, Daniel Stone wrote:
>> DRI3 version 1.1 adds support for explicit format modifiers, including
>> multi-planar buffers.
>>
>> Signed-off-by: Daniel Stone <daniels at collabora.com>
>> ---
>>  dri3proto.h | 142 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>  1 file changed, 140 insertions(+), 2 deletions(-)
>
> Should update dri3proto.txt too.

Good point, will be fixed for v2.

>> +typedef struct {
>> +    [...]
>> +    CARD32  stride0 B32;
>> +    CARD32  offset0 B32;
>> +    CARD32  stride1 B32;
>> +    CARD32  offset1 B32;
>> +    CARD32  stride2 B32;
>> +    CARD32  offset2 B32;
>> +    CARD32  stride3 B32;
>> +    CARD32  offset3 B32;
>> +    [...]
>> +} xDRI3PixmapFromBuffersReq;
>> +#define sz_xDRI3PixmapFromBuffersReq 64
>
> Why exactly four strides/offsets?

Because that's what KMS takes for AddFB2, and (not coincidentally)
what EGL_EXT_image_dma_buf_import_modifiers also defines tokens for. I
don't even know of anyone using four, which would be tri-planar Y/U/V
with an auxiliary plane. But seemed prudent to line up with the
external APIs.

Cheers,
Daniel